Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate from safetynet to playintegrity (VO-208) #1438

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: Migrate from safetynet to playintegrity (VO-208) #1438

merged 2 commits into from
Jan 17, 2024

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Jan 16, 2024 •
edited
Loading

Implement

  • Remove SafetyNet from cozy-client
  • Add Google Play Integrity to cozy-client

Remarks

  • API remains unchanged
  • React-native package is forked for now
  • Documentation updated

References

@acezard acezard marked this pull request as draft January 16, 2024 09:55
@acezard acezard force-pushed the feat--migrate-from-safetynet-to-playintegrity branch 2 times, most recently from 0816606 to 3e9a6e2 Compare January 16, 2024 13:37
@acezard acezard force-pushed the feat--migrate-from-safetynet-to-playintegrity branch from 3e9a6e2 to 7389d29 Compare January 16, 2024 14:56
@acezard acezard marked this pull request as ready for review January 16, 2024 15:03
Ldoppea
Ldoppea approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@Ldoppea Ldoppea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice if we can now replace the deprecated Safetynet API 🎉

@acezard
fix: Add store issuer in attestation request
6a9a21f 
The cozy-stack requires it for integration API
@acezard
Copy link
Contributor Author

acezard commented Jan 17, 2024

Looks good. Nice if we can now replace the deprecated Safetynet API 🎉

yes the really minimal API changes is really good. BTW I added a commit for the issuer field. It is now required by the cozy-stack for playintegrity, will remain undefined for iOS

@acezard acezard merged commit 1bf5ce6 into master Jan 17, 2024
4 checks passed
@acezard acezard deleted the feat--migrate-from-safetynet-to-playintegrity branch January 17, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Ldoppea approved these changes

@Crash-- Crash-- Awaiting requested review from Crash--

@Merkur39 Merkur39 Awaiting requested review from Merkur39 Merkur39 is a code owner

@paultranvan paultranvan Awaiting requested review from paultranvan paultranvan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acezard @Ldoppea